From issues-return-6308-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Thu Apr 25 21:38:06 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id DD3C0180638 for ; Thu, 25 Apr 2019 23:38:05 +0200 (CEST) Received: (qmail 86879 invoked by uid 500); 25 Apr 2019 21:38:02 -0000 Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list issues@phoenix.apache.org Received: (qmail 86838 invoked by uid 99); 25 Apr 2019 21:38:02 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 Apr 2019 21:38:02 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D0320E2B2F for ; Thu, 25 Apr 2019 21:38:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1016625810 for ; Thu, 25 Apr 2019 21:38:00 +0000 (UTC) Date: Thu, 25 Apr 2019 21:38:00 +0000 (UTC) From: "Josh Elser (JIRA)" To: issues@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PHOENIX-5213) Phoenix-client improvements: add more relocations, exclude log binding, add source jar MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-5213?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16= 826487#comment-16826487 ]=20 Josh Elser commented on PHOENIX-5213: ------------------------------------- {quote}That line is actually including a symlink, not an actual jar. {quote} Tricky! I assume that we'd eventually want to do this for the other top-level jars = too, right? (e.g. phoenix-queryserver-client, phoenix-server, phoenix-hive,= etc). Don't need to do them all here and now =E2=80=93 something as a foll= ow-on. LGTM. Sorry for the delay, was out last week and still digging out from eve= rything. > Phoenix-client improvements: add more relocations, exclude log binding, = add source jar > -------------------------------------------------------------------------= -------------- > > Key: PHOENIX-5213 > URL: https://issues.apache.org/jira/browse/PHOENIX-5213 > Project: Phoenix > Issue Type: Improvement > Affects Versions: 5.0.0, 4.15.0 > Reporter: Vincent Poon > Assignee: Vincent Poon > Priority: Major > Attachments: PHOENIX-5213.4.x-HBase-1.4.v1.patch, PHOENIX-5213.4.= x-HBase-1.4.v2.patch, PHOENIX-5213.4.x-HBase-1.4.v3.patch, PHOENIX-5213.4.x= -HBase-1.4.v4.patch > > > To make the existing phoenix-client, I'm proposing the following changes: > 1) Add additional relocations of some packages > Add a new "embedded" classifier to phoenix-client that does the following= :=20 > 2) Exclude the slf4j-log4j12 binding. Apparently this isn't pulled in d= irectly from phoenix-core itself, but transitively from other projects. It= 's generally considered best practice to not impose a log binding on downst= ream projects. The slf4j-log4j12 jar will still be in the phoenix tarball'= s /lib folder. > 3) Create a source jar for phoenix-client embedded. > 4) Create a dependency-reduced pom, so that the client can be used direc= tly in downstream projects without having to exclude transitive artifacts. > 5) rename the jar to match the final name in the repository: phoenix-cli= ent-{version}.jar There is now a symlink phoenix-{version}-client.jar to m= aintain backwards compatibility. -- This message was sent by Atlassian JIRA (v7.6.3#76005)