From issues-return-5606-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Wed Apr 3 00:57:03 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id B885A180668 for ; Wed, 3 Apr 2019 02:57:02 +0200 (CEST) Received: (qmail 12900 invoked by uid 500); 3 Apr 2019 00:57:01 -0000 Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list issues@phoenix.apache.org Received: (qmail 12889 invoked by uid 99); 3 Apr 2019 00:57:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Apr 2019 00:57:01 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 54ADAE008D for ; Wed, 3 Apr 2019 00:57:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id C561624422 for ; Wed, 3 Apr 2019 00:57:00 +0000 (UTC) Date: Wed, 3 Apr 2019 00:57:00 +0000 (UTC) From: "Hadoop QA (JIRA)" To: issues@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PHOENIX-5190) Implement a TaskRegionObserver for index rebuilds MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-5190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16808268#comment-16808268 ] Hadoop QA commented on PHOENIX-5190: ------------------------------------ {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12964638/PHOENIX-5190-4.x.patch against master branch at commit 507e6b5a0f0c94cd85ed359cd04d92e849743a31. ATTACHMENT ID: 12964638 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:red}-1 patch{color}. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2473//console This message is automatically generated. > Implement a TaskRegionObserver for index rebuilds > ------------------------------------------------- > > Key: PHOENIX-5190 > URL: https://issues.apache.org/jira/browse/PHOENIX-5190 > Project: Phoenix > Issue Type: Improvement > Reporter: Gokcen Iskender > Assignee: Gokcen Iskender > Priority: Major > Attachments: PHOENIX-5190-4.x.patch, PHOENIX-5190.patch > > Time Spent: 2h 50m > Remaining Estimate: 0h > > A new way to kick index rebuilds is putting an entry to System.Tasks table. > IndexRebuildTask is a new TaskRegionObserver. It will look at this table, kick the index rebuild and mark the task status. > This work requires updates to the System.Tasks table. -- This message was sent by Atlassian JIRA (v7.6.3#76005)