From issues-return-5810-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Tue Apr 9 20:42:02 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id E608B180763 for ; Tue, 9 Apr 2019 22:42:01 +0200 (CEST) Received: (qmail 33000 invoked by uid 500); 9 Apr 2019 20:22:23 -0000 Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list issues@phoenix.apache.org Received: (qmail 32957 invoked by uid 99); 9 Apr 2019 20:22:23 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Apr 2019 20:22:23 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 85F2AE2A74 for ; Tue, 9 Apr 2019 20:42:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 321302459B for ; Tue, 9 Apr 2019 20:42:00 +0000 (UTC) Date: Tue, 9 Apr 2019 20:42:00 +0000 (UTC) From: "Hudson (JIRA)" To: issues@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PHOENIX-5138) ViewIndexId sequences created after PHOENIX-5132 shouldn't collide with ones created before it MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-5138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16813793#comment-16813793 ] Hudson commented on PHOENIX-5138: --------------------------------- FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #2500 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/2500/]) PHOENIX-5138 - ViewIndexId sequences created after PHOENIX-5132 (gjacoby: rev 6ca7ff61ca9d8d89343fb331aed25afe174c8ca5) * (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/util/MetaDataUtil.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/util/UpgradeUtil.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/index/ViewIndexIT.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/UpgradeIT.java > ViewIndexId sequences created after PHOENIX-5132 shouldn't collide with ones created before it > ---------------------------------------------------------------------------------------------- > > Key: PHOENIX-5138 > URL: https://issues.apache.org/jira/browse/PHOENIX-5138 > Project: Phoenix > Issue Type: Bug > Affects Versions: 4.15.0, 5.1 > Reporter: Geoffrey Jacoby > Assignee: Geoffrey Jacoby > Priority: Blocker > Fix For: 4.15.0, 5.1.0 > > Attachments: PHOENIX-5138-v2.patch, PHOENIX-5138-v3.patch, PHOENIX-5138-v4.patch, PHOENIX-5138.patch > > Time Spent: 4h 10m > Remaining Estimate: 0h > > PHOENIX-5132 changed the ViewIndexId generation logic to use one sequence per physical view index table, whereas before it had been tenant + physical table. This removed the possibility of a tenant view index and a global view index having colliding ViewIndexIds. > However, existing Phoenix environments may have already created tenant-owned view index ids using the old sequence, and under PHOENIX-5132 if they create another, its ViewIndexId will got back to MIN_VALUE, which could cause a collision with an existing view index id. -- This message was sent by Atlassian JIRA (v7.6.3#76005)