From issues-return-6451-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Tue Apr 30 21:17:40 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id A9E5718072F for ; Tue, 30 Apr 2019 23:17:39 +0200 (CEST) Received: (qmail 46715 invoked by uid 500); 30 Apr 2019 21:17:39 -0000 Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list issues@phoenix.apache.org Received: (qmail 46660 invoked by uid 99); 30 Apr 2019 21:17:39 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 30 Apr 2019 21:17:39 +0000 From: GitBox To: issues@phoenix.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bphoenix-connectors=5D_ChinmaySKulkarni_commente?= =?utf-8?q?d_on_a_change_in_pull_request_=234=3A_PHOENIX-5238_Provide_an_o?= =?utf-8?q?ption_to_pass_hints_with_PhoenixRDD_and_Data=E2=80=A6?= Message-ID: <155665905896.7394.12019037527772796478.gitbox@gitbox.apache.org> Date: Tue, 30 Apr 2019 21:17:38 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit ChinmaySKulkarni commented on a change in pull request #4: PHOENIX-5238 Provide an option to pass hints with PhoenixRDD and Data… URL: https://github.com/apache/phoenix-connectors/pull/4#discussion_r279940056 ########## File path: phoenix-spark/src/test/java/org/apache/phoenix/spark/datasource/v2/PhoenixDataSourceTest.java ########## @@ -64,6 +67,8 @@ public void testPhoenixConfigsExtractedProperly() { assertEquals(V1, p.getProperty(P1)); assertEquals(V2, p.getProperty(P2)); assertEquals(V3, p.getProperty(P3)); + assertEquals(V3, p.getProperty(P3)); + assertEquals(true, Boolean.valueOf(p.getProperty(NO_CACHE))); Review comment: This test isn't testing your change at all..Here you are using the extraOptions to set the property and just checking that the property is set. Ideally, we want to use extraOptions to set HBase/Phoenix properties if they are valid configs we set in say hbase-site.xml. In this case, `NO_CACHE` is not such a config so we are using a different way to set this. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services