From issues-return-6419-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Tue Apr 30 03:42:46 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 6014418061A for ; Tue, 30 Apr 2019 05:42:46 +0200 (CEST) Received: (qmail 65559 invoked by uid 500); 30 Apr 2019 03:42:45 -0000 Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list issues@phoenix.apache.org Received: (qmail 65537 invoked by uid 99); 30 Apr 2019 03:42:45 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 30 Apr 2019 03:42:45 +0000 From: GitBox To: issues@phoenix.apache.org Subject: [GitHub] [phoenix-queryserver] swaroopak commented on a change in pull request #5: PHOENIX-5255: Create Orchestrator for QueryServerCanaryTool in phoenix-queryserver project Message-ID: <155659576561.19171.6228568378933975671.gitbox@gitbox.apache.org> Date: Tue, 30 Apr 2019 03:42:45 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit swaroopak commented on a change in pull request #5: PHOENIX-5255: Create Orchestrator for QueryServerCanaryTool in phoenix-queryserver project URL: https://github.com/apache/phoenix-queryserver/pull/5#discussion_r279606218 ########## File path: queryserver-orchestrator/src/main/java/org/apache/phoenix/queryserver/orchestrator/LoggingCanarySink.java ########## @@ -0,0 +1,75 @@ +package org.apache.phoenix.queryserver.orchestrator; + +import com.google.common.annotations.VisibleForTesting; +import com.google.common.base.Preconditions; +import com.google.common.base.Strings; +import com.google.gson.Gson; +import com.google.gson.GsonBuilder; +import org.apache.phoenix.tool.CanaryTestResult; +import org.apache.phoenix.tool.PhoenixCanaryTool; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.text.SimpleDateFormat; +import java.util.ArrayList; +import java.util.Date; +import java.util.List; + +public class LoggingCanarySink implements PhoenixCanaryTool.Sink { Review comment: yet to be addressed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services