From issues-return-6384-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Mon Apr 29 18:42:46 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 4CD2818061A for ; Mon, 29 Apr 2019 20:42:46 +0200 (CEST) Received: (qmail 24637 invoked by uid 500); 29 Apr 2019 18:42:45 -0000 Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list issues@phoenix.apache.org Received: (qmail 24594 invoked by uid 99); 29 Apr 2019 18:42:45 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 29 Apr 2019 18:42:45 +0000 From: GitBox To: issues@phoenix.apache.org Subject: [GitHub] [phoenix] priyankporwal commented on a change in pull request #469: PHOENIX-5156 Consistent Global Indexes for Non-Transactional Tables Message-ID: <155656336539.26591.15097561715209042338.gitbox@gitbox.apache.org> Date: Mon, 29 Apr 2019 18:42:45 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit priyankporwal commented on a change in pull request #469: PHOENIX-5156 Consistent Global Indexes for Non-Transactional Tables URL: https://github.com/apache/phoenix/pull/469#discussion_r279109142 ########## File path: phoenix-core/src/main/java/org/apache/phoenix/util/UpgradeUtil.java ########## @@ -1418,6 +1420,14 @@ public static void syncTableAndIndexProperties(PhoenixConnection conn, Admin adm continue; } if (table.getType() == PTableType.INDEX) { + if (table.getIndexType() == IndexType.GLOBAL && + !table.isTransactional() && + !table.isImmutableRows() && Review comment: Should the isTransactional() and isImmutableRows() checks be done on the originalTableDesc or the index table? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services