From issues-return-6374-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Mon Apr 29 15:37:20 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 2413518061A for ; Mon, 29 Apr 2019 17:37:20 +0200 (CEST) Received: (qmail 1460 invoked by uid 500); 29 Apr 2019 15:37:19 -0000 Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list issues@phoenix.apache.org Received: (qmail 1441 invoked by uid 99); 29 Apr 2019 15:37:19 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 29 Apr 2019 15:37:19 +0000 From: GitBox To: issues@phoenix.apache.org Subject: [GitHub] [phoenix] BinShi-SecularBird commented on a change in pull request #494: PHOENIX-5262 Wrong Result on Salted table with Varbinary PK Message-ID: <155655223426.14393.5360941075239231045.gitbox@gitbox.apache.org> Date: Mon, 29 Apr 2019 15:37:14 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit BinShi-SecularBird commented on a change in pull request #494: PHOENIX-5262 Wrong Result on Salted table with Varbinary PK URL: https://github.com/apache/phoenix/pull/494#discussion_r279418816 ########## File path: phoenix-core/src/test/java/org/apache/phoenix/util/ScanUtilTest.java ########## @@ -45,291 +48,305 @@ /** * Test the SetKey method in ScanUtil. */ -@RunWith(Parameterized.class) +@RunWith(Enclosed.class) public class ScanUtilTest { - private final List> slots; - private final byte[] expectedKey; - private final RowKeySchema schema; - private final Bound bound; - - public ScanUtilTest(List> slots, int[] widths, byte[] expectedKey, Bound bound) throws Exception { - RowKeySchemaBuilder builder = new RowKeySchemaBuilder(widths.length); - for (final int width : widths) { - if (width > 0) { - builder.addField(new PDatum() { - @Override - public boolean isNullable() { - return false; - } - @Override - public PDataType getDataType() { - return PChar.INSTANCE; - } - @Override - public Integer getMaxLength() { - return width; - } - @Override - public Integer getScale() { - return null; - } - @Override - public SortOrder getSortOrder() { - return SortOrder.getDefault(); - } - }, false, SortOrder.getDefault()); - } else { - builder.addField(new PDatum() { - @Override - public boolean isNullable() { - return false; - } - @Override - public PDataType getDataType() { - return PVarchar.INSTANCE; - } - @Override - public Integer getMaxLength() { - return null; - } - @Override - public Integer getScale() { - return null; - } - @Override - public SortOrder getSortOrder() { - return SortOrder.getDefault(); - } - }, false, SortOrder.getDefault()); + @RunWith(Parameterized.class) + public static class ParameterizedScanUtilTest { + + Review comment: remove the blank lines at 56 and 57? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services