From issues-return-6369-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Sun Apr 28 04:50:40 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id B8559180630 for ; Sun, 28 Apr 2019 06:50:39 +0200 (CEST) Received: (qmail 6019 invoked by uid 500); 28 Apr 2019 04:50:39 -0000 Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list issues@phoenix.apache.org Received: (qmail 6010 invoked by uid 99); 28 Apr 2019 04:50:38 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 28 Apr 2019 04:50:38 +0000 From: GitBox To: issues@phoenix.apache.org Subject: [GitHub] [phoenix] swaroopak commented on a change in pull request #494: PHOENIX-5262 Wrong Result on Salted table with Varbinary PK Message-ID: <155642703884.16106.5503424219471774480.gitbox@gitbox.apache.org> Date: Sun, 28 Apr 2019 04:50:38 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit swaroopak commented on a change in pull request #494: PHOENIX-5262 Wrong Result on Salted table with Varbinary PK URL: https://github.com/apache/phoenix/pull/494#discussion_r279177323 ########## File path: phoenix-core/src/test/java/org/apache/phoenix/util/ScanUtilTest.java ########## @@ -45,291 +48,305 @@ /** * Test the SetKey method in ScanUtil. */ -@RunWith(Parameterized.class) +@RunWith(Enclosed.class) Review comment: Nice! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services