From issues-return-5921-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Wed Apr 10 23:45:05 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id D531D180626 for ; Thu, 11 Apr 2019 01:45:04 +0200 (CEST) Received: (qmail 98880 invoked by uid 500); 10 Apr 2019 23:45:03 -0000 Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list issues@phoenix.apache.org Received: (qmail 98871 invoked by uid 99); 10 Apr 2019 23:45:03 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Apr 2019 23:45:03 +0000 From: GitBox To: issues@phoenix.apache.org Subject: [GitHub] [phoenix-connectors] ChinmaySKulkarni commented on a change in pull request #3: PHOENIX-5232: PhoenixDataWriter in Phoenix-Spark connector does not commit when mutation batch size is reached Message-ID: <155493990414.31238.10556382401694905572.gitbox@gitbox.apache.org> Date: Wed, 10 Apr 2019 23:45:04 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit ChinmaySKulkarni commented on a change in pull request #3: PHOENIX-5232: PhoenixDataWriter in Phoenix-Spark connector does not commit when mutation batch size is reached URL: https://github.com/apache/phoenix-connectors/pull/3#discussion_r274213417 ########## File path: phoenix-spark/src/test/java/org/apache/phoenix/spark/datasource/v2/writer/PhoenixTestingDataWriter.java ########## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.phoenix.spark.datasource.v2.writer; + +import org.apache.spark.sql.sources.v2.writer.WriterCommitMessage; + +import java.sql.SQLException; + +public class PhoenixTestingDataWriter extends PhoenixDataWriter { + + private long numBatchesCommitted = 0; + + PhoenixTestingDataWriter(PhoenixDataSourceWriteOptions options) { + super(options); + } + + // Override to also count the number of times we call this method to test upsert batch commits Review comment: The reason for most of the 1-liner comments is that _why_ the method is being overridden to do what it is doing, is not obvious. The actual overriding part is not being explained. As for adding a description for each class, the underlying interface in all cases has in-depth descriptions. For example: `PhoenixTestingDataSourceWriter` -> `PhoenixDataSourceWriter` --> `DataSourceWriter` and `DataSourceWriter` contains the description. This also avoids redundant comments amongst interfaces and implementing classes. Is there anything specific that you would like me to add? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services