From issues-return-5909-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Wed Apr 10 23:20:46 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3A371180784 for ; Thu, 11 Apr 2019 01:20:46 +0200 (CEST) Received: (qmail 23782 invoked by uid 500); 10 Apr 2019 23:20:45 -0000 Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list issues@phoenix.apache.org Received: (qmail 23773 invoked by uid 99); 10 Apr 2019 23:20:45 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Apr 2019 23:20:45 +0000 From: GitBox To: issues@phoenix.apache.org Subject: [GitHub] [phoenix-connectors] swaroopak commented on a change in pull request #3: PHOENIX-5232: PhoenixDataWriter in Phoenix-Spark connector does not commit when mutation batch size is reached Message-ID: <155493844554.14859.10394055365207185144.gitbox@gitbox.apache.org> Date: Wed, 10 Apr 2019 23:20:45 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit swaroopak commented on a change in pull request #3: PHOENIX-5232: PhoenixDataWriter in Phoenix-Spark connector does not commit when mutation batch size is reached URL: https://github.com/apache/phoenix-connectors/pull/3#discussion_r274200084 ########## File path: phoenix-spark/src/main/java/org/apache/phoenix/spark/datasource/v2/reader/PhoenixInputPartitionReader.java ########## @@ -62,25 +62,30 @@ public class PhoenixInputPartitionReader implements InputPartitionReader { - private SerializableWritable phoenixInputSplit; - private StructType schema; + private final SerializableWritable phoenixInputSplit; + private final StructType schema; + private final PhoenixDataSourceReadOptions options; private Iterator iterator; private PhoenixResultSet resultSet; private InternalRow currentRow; - private PhoenixDataSourceReadOptions options; - public PhoenixInputPartitionReader(PhoenixDataSourceReadOptions options, StructType schema, SerializableWritable phoenixInputSplit) { + PhoenixInputPartitionReader(PhoenixDataSourceReadOptions options, StructType schema, Review comment: Making it accessible only within the package, is that the intent? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services