From issues-return-5908-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Wed Apr 10 23:20:46 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id D5E0D180626 for ; Thu, 11 Apr 2019 01:20:45 +0200 (CEST) Received: (qmail 23689 invoked by uid 500); 10 Apr 2019 23:20:45 -0000 Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list issues@phoenix.apache.org Received: (qmail 23651 invoked by uid 99); 10 Apr 2019 23:20:45 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Apr 2019 23:20:45 +0000 From: GitBox To: issues@phoenix.apache.org Subject: [GitHub] [phoenix-connectors] swaroopak commented on a change in pull request #3: PHOENIX-5232: PhoenixDataWriter in Phoenix-Spark connector does not commit when mutation batch size is reached Message-ID: <155493844517.14857.12180968948466435990.gitbox@gitbox.apache.org> Date: Wed, 10 Apr 2019 23:20:45 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit swaroopak commented on a change in pull request #3: PHOENIX-5232: PhoenixDataWriter in Phoenix-Spark connector does not commit when mutation batch size is reached URL: https://github.com/apache/phoenix-connectors/pull/3#discussion_r274199400 ########## File path: phoenix-spark/src/it/scala/org/apache/phoenix/spark/PhoenixSparkIT.scala ########## @@ -16,12 +16,17 @@ package org.apache.phoenix.spark import java.sql.DriverManager import java.util.Date +import org.apache.phoenix.mapreduce.util.PhoenixConfigurationUtil import org.apache.phoenix.schema.types.PVarchar -import org.apache.phoenix.spark.datasource.v2.PhoenixDataSource +import org.apache.phoenix.spark.datasource.v2.{PhoenixDataSource, PhoenixTestingDataSource} +import org.apache.phoenix.spark.datasource.v2.reader.PhoenixTestingInputPartitionReader +import org.apache.phoenix.spark.datasource.v2.writer.PhoenixTestingDataSourceWriter import org.apache.phoenix.util.{ColumnInfo, SchemaUtil} +import org.apache.spark.SparkException import org.apache.spark.sql.types._ Review comment: not relates to this PR, does this mean everything? do we need all of them? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services