From issues-return-5818-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Tue Apr 9 20:56:08 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 05CEF180763 for ; Tue, 9 Apr 2019 22:56:07 +0200 (CEST) Received: (qmail 76991 invoked by uid 500); 9 Apr 2019 20:36:29 -0000 Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list issues@phoenix.apache.org Received: (qmail 76981 invoked by uid 99); 9 Apr 2019 20:36:29 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Apr 2019 20:36:29 +0000 From: GitBox To: issues@phoenix.apache.org Subject: [GitHub] [phoenix] karanmehta93 commented on a change in pull request #479: PHOENIX-5231 Configurable Stats Cache Message-ID: <155484336731.2828.15225087491758816775.gitbox@gitbox.apache.org> Date: Tue, 09 Apr 2019 20:56:07 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit karanmehta93 commented on a change in pull request #479: PHOENIX-5231 Configurable Stats Cache URL: https://github.com/apache/phoenix/pull/479#discussion_r273698244 ########## File path: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java ########## @@ -420,8 +421,11 @@ public ConnectionQueryServicesImpl(QueryServices services, ConnectionInfo connec list.add(queue); } connectionQueues = ImmutableList.copyOf(list); + // A little bit of a smell to leak `this` here, but should not be a problem - this.tableStatsCache = new GuidePostsCache(this, config); + this.tableStatsCache = queryServicesHelper.getGuidePostsCache(props.get(GUIDE_POSTS_CACHE_FACTORY_CLASS, + QueryServicesOptions.DEFAULT_GUIDE_POSTS_CACHE_FACTORY_CLASS), this, config); Review comment: Just curious, may be we don't even need it? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services