From issues-return-5816-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Tue Apr 9 20:51:27 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 1BF4D180763 for ; Tue, 9 Apr 2019 22:51:27 +0200 (CEST) Received: (qmail 62561 invoked by uid 500); 9 Apr 2019 20:31:49 -0000 Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list issues@phoenix.apache.org Received: (qmail 62541 invoked by uid 99); 9 Apr 2019 20:31:49 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Apr 2019 20:31:48 +0000 From: GitBox To: issues@phoenix.apache.org Subject: [GitHub] [phoenix] karanmehta93 commented on a change in pull request #479: PHOENIX-5231 Configurable Stats Cache Message-ID: <155484308631.599.9768328531999411898.gitbox@gitbox.apache.org> Date: Tue, 09 Apr 2019 20:51:26 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit karanmehta93 commented on a change in pull request #479: PHOENIX-5231 Configurable Stats Cache URL: https://github.com/apache/phoenix/pull/479#discussion_r273694446 ########## File path: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionlessQueryServicesImpl.java ########## @@ -600,7 +604,12 @@ public String getUserName() { @Override public GuidePostsInfo getTableStats(GuidePostsKey key) { - GuidePostsInfo info = guidePostsCache.getCache().getIfPresent(key); + GuidePostsInfo info = null; Review comment: Do we need to handle this exception in a similar way in `ConnectionQueryServicesImpl.java`? We may not be able to move to parent class because I believe that Java 7 doesn't support default methods in interfaces, right? Do you think there is a better way? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services