From issues-return-5758-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Mon Apr 8 20:31:42 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id CDFA8180654 for ; Mon, 8 Apr 2019 22:31:41 +0200 (CEST) Received: (qmail 39605 invoked by uid 500); 8 Apr 2019 20:12:03 -0000 Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list issues@phoenix.apache.org Received: (qmail 39593 invoked by uid 99); 8 Apr 2019 20:12:03 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Apr 2019 20:12:03 +0000 From: GitBox To: issues@phoenix.apache.org Subject: [GitHub] [phoenix] ChinmaySKulkarni commented on issue #477: PHOENIX-5230 Fix ChangePermissionsIT and TableDDLPermissionIT on master Message-ID: <155475550111.18419.15002746011815204745.gitbox@gitbox.apache.org> Date: Mon, 08 Apr 2019 20:31:41 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit ChinmaySKulkarni commented on issue #477: PHOENIX-5230 Fix ChangePermissionsIT and TableDDLPermissionIT on master URL: https://github.com/apache/phoenix/pull/477#issuecomment-480996063 One question on the `FixMethodOrder` change. Otherwise, lgtm. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services