From issues-return-5725-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Fri Apr 5 21:56:30 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 692C518067E for ; Fri, 5 Apr 2019 23:56:29 +0200 (CEST) Received: (qmail 12825 invoked by uid 500); 5 Apr 2019 21:56:28 -0000 Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list issues@phoenix.apache.org Received: (qmail 12796 invoked by uid 99); 5 Apr 2019 21:56:28 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Apr 2019 21:56:28 +0000 From: GitBox To: issues@phoenix.apache.org Subject: [GitHub] [phoenix] swaroopak commented on a change in pull request #477: PHOENIX-5230 Fix ChangePermissionsIT and TableDDLPermissionIT on master Message-ID: <155450138797.19099.7891273760773919986.gitbox@gitbox.apache.org> Date: Fri, 05 Apr 2019 21:56:27 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit swaroopak commented on a change in pull request #477: PHOENIX-5230 Fix ChangePermissionsIT and TableDDLPermissionIT on master URL: https://github.com/apache/phoenix/pull/477#discussion_r272755652 ########## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/BasePermissionsIT.java ########## @@ -16,62 +16,66 @@ */ package org.apache.phoenix.end2end; -import static org.junit.Assert.assertEquals; -import static org.junit.Assert.assertFalse; -import static org.junit.Assert.assertNotNull; -import static org.junit.Assert.assertTrue; -import static org.junit.Assert.fail; - -import java.io.IOException; -import java.lang.reflect.UndeclaredThrowableException; -import java.security.PrivilegedExceptionAction; -import java.sql.Connection; -import java.sql.DriverManager; -import java.sql.PreparedStatement; -import java.sql.ResultSet; -import java.sql.SQLException; -import java.sql.Statement; -import java.util.Arrays; -import java.util.Collection; -import java.util.Collections; -import java.util.HashSet; -import java.util.List; -import java.util.Properties; -import java.util.Set; - +import com.google.common.base.Joiner; +import com.google.common.base.Throwables; import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; import org.apache.hadoop.conf.Configuration; import org.apache.hadoop.hbase.AuthUtil; import org.apache.hadoop.hbase.HBaseTestingUtility; -import org.apache.hadoop.hbase.HConstants; import org.apache.hadoop.hbase.LocalHBaseCluster; +import org.apache.hadoop.hbase.NamespaceDescriptor; import org.apache.hadoop.hbase.TableName; import org.apache.hadoop.hbase.security.AccessDeniedException; import org.apache.hadoop.hbase.security.User; import org.apache.hadoop.hbase.security.access.AccessControlClient; import org.apache.hadoop.hbase.security.access.Permission; +import org.apache.phoenix.coprocessor.MetaDataProtocol; import org.apache.phoenix.jdbc.PhoenixConnection; import org.apache.phoenix.jdbc.PhoenixDatabaseMetaData; import org.apache.phoenix.jdbc.PhoenixStatement; import org.apache.phoenix.query.BaseTest; import org.apache.phoenix.query.QueryConstants; import org.apache.phoenix.query.QueryServices; +import org.apache.phoenix.schema.NewerSchemaAlreadyExistsException; +import org.apache.phoenix.schema.TableNotFoundException; import org.apache.phoenix.util.PhoenixRuntime; -import org.junit.After; -import org.junit.BeforeClass; -import org.junit.runner.RunWith; -import org.junit.runners.Parameterized; +import org.apache.phoenix.util.SchemaUtil; +import org.junit.Before; +import org.junit.FixMethodOrder; +import org.junit.Test; +import org.junit.experimental.categories.Category; +import org.junit.runners.MethodSorters; -import com.google.common.base.Joiner; -import com.google.common.base.Throwables; +import java.io.IOException; +import java.lang.reflect.UndeclaredThrowableException; +import java.security.PrivilegedExceptionAction; +import java.sql.Connection; +import java.sql.DriverManager; +import java.sql.PreparedStatement; +import java.sql.ResultSet; +import java.sql.SQLException; +import java.sql.Statement; +import java.util.Arrays; +import java.util.Collections; +import java.util.HashSet; +import java.util.List; +import java.util.Properties; +import java.util.Set; + +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertFalse; +import static org.junit.Assert.assertNotNull; +import static org.junit.Assert.assertTrue; +import static org.junit.Assert.fail; -@RunWith(Parameterized.class) +@Category(NeedsOwnMiniClusterTest.class) +@FixMethodOrder(MethodSorters.NAME_ASCENDING) public class BasePermissionsIT extends BaseTest { private static final Log LOG = LogFactory.getLog(BasePermissionsIT.class); - static String SUPERUSER; + static String SUPERUSER = System.getProperty("user.name"); Review comment: nit: SUPER_USER ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services