From issues-return-5709-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Fri Apr 5 21:08:53 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id A7BCE180780 for ; Fri, 5 Apr 2019 23:08:51 +0200 (CEST) Received: (qmail 9440 invoked by uid 500); 5 Apr 2019 21:08:50 -0000 Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list issues@phoenix.apache.org Received: (qmail 9341 invoked by uid 99); 5 Apr 2019 21:08:50 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Apr 2019 21:08:50 +0000 From: GitBox To: issues@phoenix.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bphoenix=5D_swaroopak_commented_on_a_change_in_p?= =?utf-8?q?ull_request_=23473=3A_PHOENIX-5138_-_ViewIndexId_sequences_crea?= =?utf-8?q?ted_after_PHOENIX-5132_shoul=E2=80=A6?= Message-ID: <155449853022.16415.13825908575571247525.gitbox@gitbox.apache.org> Date: Fri, 05 Apr 2019 21:08:50 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit swaroopak commented on a change in pull request #473: PHOENIX-5138 - ViewIndexId sequences created after PHOENIX-5132 shoul… URL: https://github.com/apache/phoenix/pull/473#discussion_r272732631 ########## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/index/ViewIndexIT.java ########## @@ -153,15 +153,10 @@ public void testDeleteViewIndexSequences() throws Exception { conn2.createStatement().executeQuery("SELECT * FROM " + fullTableName).next(); String sequenceName = getViewIndexSequenceName(PNameFactory.newName(fullTableName), null, isNamespaceMapped); String sequenceSchemaName = getViewIndexSequenceSchemaName(PNameFactory.newName(fullTableName), isNamespaceMapped); - String seqName = getViewIndexSequenceName(PNameFactory.newName(fullTableName), null, !isNamespaceMapped); - String seqSchemaName = getViewIndexSequenceSchemaName(PNameFactory.newName(fullTableName), !isNamespaceMapped); verifySequenceValue(null, sequenceName, sequenceSchemaName, -9223372036854775807L); verifySequenceValue(null, sequenceName, sequenceSchemaName, -9223372036854775807L); conn1.createStatement().execute("CREATE INDEX " + indexName + "_2 ON " + fullViewName + " (v1)"); verifySequenceValue(null, sequenceName, sequenceSchemaName, -9223372036854775806L); Review comment: Just curious, I see there is a difference in the last digit. any particular significance? while you are at it, can we extract this value to a constant? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services