phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-5246) PhoenixAccessControllers.getAccessControllers() method is not correctly implementing the double-checked locking
Date Sat, 20 Apr 2019 00:56:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-5246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16822297#comment-16822297
] 

Hadoop QA commented on PHOENIX-5246:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12966515/PHOENIX-5246.4.x-HBase-1.3.v1.patch
  against 4.x-HBase-1.3 branch at commit f80c5b1c74a1e6903e3417a9a19c1a53d74552e0.
  ATTACHMENT ID: 12966515

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 6 release audit warnings
(more than the master's current 0 warnings).

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.execute.PartialCommitIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.IndexRebuildTaskIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.join.HashJoinMoreIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.UpgradeIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.txn.TxWriteFailureIT

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2517//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2517//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2517//console

This message is automatically generated.

> PhoenixAccessControllers.getAccessControllers() method is not correctly implementing
the double-checked locking
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-5246
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5246
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.14.0
>            Reporter: Thomas D'Silva
>            Assignee: Swaroopa Kadam
>            Priority: Major
>              Labels: SFDC
>             Fix For: 4.15.0, 5.1.0, 4.14.2
>
>         Attachments: PHOENIX-5246.4.x-HBase-1.3.v1.patch
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> By [~elserj] on PHOENIX-5070: 
> This looks to me that the getAccessControllers() method is not correctly implementing
the double-checked locking "approach" as per https://en.wikipedia.org/wiki/Double-checked_locking#Usage_in_Java
(the accessControllers variable must be volatile).
> If we want to avoid taking an explicit lock, what about using AtomicReference instead?
Can we spin out another Jira issue to fix that?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message