phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chinmay Kulkarni (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-5243) PhoenixResultSet#next() closes the result set if scanner returns null
Date Thu, 18 Apr 2019 00:42:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-5243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16820611#comment-16820611
] 

Chinmay Kulkarni commented on PHOENIX-5243:
-------------------------------------------

[~swaroopa] For your new changes in QueryLoggerIT, the close statements will not be called
in case there is an exception after a resource is opened. Ideally, we should use try-with-resources
for these blocks. Can you please amend the patch to do this?

> PhoenixResultSet#next() closes the result set if scanner returns null
> ---------------------------------------------------------------------
>
>                 Key: PHOENIX-5243
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5243
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Swaroopa Kadam
>            Assignee: Swaroopa Kadam
>            Priority: Minor
>             Fix For: 4.14.2
>
>         Attachments: PHOENIX-5243.4.x-HBase-1.3.v1.patch, PHOENIX-5243.4.x-HBase-1.3.v2.patch,
PHOENIX-5243.4.x-HBase-1.3.v3.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message