phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-5231) Configurable Stats Cache
Date Tue, 16 Apr 2019 19:05:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-5231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16819402#comment-16819402
] 

Hadoop QA commented on PHOENIX-5231:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12966128/PHOENIX-5231.v2.patch
  against master branch at commit 2e12af8e0d8c58a7ad4178b0476057d02fb1a7a3.
  ATTACHMENT ID: 12966128

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 15 new or modified
tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 9 release audit warnings
(more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +        this.tableStatsCache = GUIDE_POSTS_CACHE_PROVIDER.getGuidePostsCache(props.get(GUIDE_POSTS_CACHE_FACTORY_CLASS,
+        this.guidePostsCache = GUIDE_POSTS_CACHE_PROVIDER.getGuidePostsCache(props.get(GUIDE_POSTS_CACHE_FACTORY_CLASS,
+    private static final Logger LOGGER = LoggerFactory.getLogger(DefaultGuidePostsCacheFactory.class);
+    @Override public GuidePostsCache getGuidePostsCache(PhoenixStatsLoader phoenixStatsLoader,
Configuration config) {
+        PhoenixStatsCacheLoader cacheLoader = new PhoenixStatsCacheLoader(phoenixStatsLoader,
config);
+    public GuidePostsInfo loadStats(GuidePostsKey statsKey, GuidePostsInfo prevGuidepostInfo)
throws Exception {
+                    logger.trace("Cached stats for {} with size={}bytes was evicted due to
cause={}",
+                    String msg = String.format("Could not load/instantiate class %s is not
an instance of GuidePostsCacheFactory", classString);
+                        LOGGER.info(String.format("Sucessfully loaded class for GuidePostsCacheFactor
of type: %s",classString));
+    public GuidePostsCacheWrapper getGuidePostsCache(String classStr, ConnectionQueryServices
queryServices, Configuration config) {

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.phoenix.jdbc.PhoenixResultSetMetadataTest
                  org.apache.phoenix.query.QueryPlanTest
                  org.apache.phoenix.compile.JoinQueryCompilerTest
                  org.apache.phoenix.compile.WhereOptimizerTest
                  org.apache.phoenix.compile.CursorCompilerTest
                  org.apache.phoenix.compile.QueryCompilerTest
                  org.apache.phoenix.compile.QueryOptimizerTest
                  org.apache.phoenix.compile.StatementHintsCompilationTest
                  org.apache.phoenix.query.ParallelIteratorsSplitTest
                  org.apache.phoenix.compile.TenantSpecificViewIndexCompileTest

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2510//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2510//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2510//console

This message is automatically generated.

> Configurable Stats Cache
> ------------------------
>
>                 Key: PHOENIX-5231
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5231
>             Project: Phoenix
>          Issue Type: Test
>            Reporter: Daniel Wong
>            Assignee: Daniel Wong
>            Priority: Major
>         Attachments: PHOENIX-5231.v2.patch
>
>          Time Spent: 6h 10m
>  Remaining Estimate: 0h
>
> Currently, the phoenix stats cache is per ConnectionQuerySerivce/ConnectionProfile, which
leads to duplicated cached entry (the guideposts) and waste resources if these separate connections
are querying the same underlying table. It would be good to be able to provide a configurable
stats cache as control the cache level so it could be per JVM.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message