phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <>
Subject [jira] [Commented] (PHOENIX-5230) Fix ChangePermissionsIT and TableDDLPermissionIT on master
Date Sun, 07 Apr 2019 08:19:00 GMT


Hadoop QA commented on PHOENIX-5230:

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment
  against master branch at commit 43600fbf39cda4336be9736fd8c653044e3d85ee.
  ATTACHMENT ID: 12965111

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 6 release audit warnings
(more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
    +    <T> void verifyDenied(User user, Class<T> exception, AccessTestAction...
actions) throws Exception {
+                                PHOENIX_NAMESPACE_MAPPED_SYSTEM_TABLES, Permission.Action.EXEC,
+                            Collections.singleton(tableName), Permission.Action.READ,Permission.Action.EXEC);
+                        grantPermissions(regularUser1.getShortName(),"SYSTEM", Permission.Action.ADMIN);
+                    props.setProperty(QueryServices.IS_NAMESPACE_MAPPING_ENABLED, Boolean.toString(isNamespaceMapped));
+                    props.setProperty(PhoenixRuntime.CURRENT_SCN_ATTRIB, Long.toString(MetaDataProtocol.MIN_SYSTEM_TABLE_TIMESTAMP));
+                verifyAllowed(grantPermissions("RX", user, QueryConstants.SYSTEM_SCHEMA_NAME,
true), superUser);
+                verifyAllowed(grantPermissions("RX", user, PHOENIX_SYSTEM_TABLES_IDENTIFIERS,
false), superUser);
+            verifyAllowed(grantPermissions("RWX", user, SYSTEM_SEQUENCE_IDENTIFIER, false),
+                verifyAllowed(revokePermissions(user, QueryConstants.SYSTEM_SCHEMA_NAME,
true), superUser);

     {color:red}-1 core tests{color}.  The patch failed these unit tests:

Test results:
Release audit warnings:
Console output:

This message is automatically generated.

> Fix ChangePermissionsIT and TableDDLPermissionIT on master
> ----------------------------------------------------------
>                 Key: PHOENIX-5230
>                 URL:
>             Project: Phoenix
>          Issue Type: Test
>            Reporter: Thomas D'Silva
>            Assignee: Thomas D'Silva
>            Priority: Major
>             Fix For: 4.15.0, 5.1.0
>         Attachments: PHOENIX-5230-4.x-HBase-1.3.patch, PHOENIX-5230.patch
>          Time Spent: 50m
>  Remaining Estimate: 0h
> The tests are failing because we are spinning up a cluster per test.

This message was sent by Atlassian JIRA

View raw message