phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-5224) Iteratively executing the same SQL query will greatly damage the performance
Date Fri, 26 Apr 2019 19:04:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-5224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16827224#comment-16827224
] 

Hadoop QA commented on PHOENIX-5224:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12966936/1.patch
  against master branch at commit c1e7744c4b2b4591c15a62421ab39c048fbc2090.
  ATTACHMENT ID: 12966936

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+0 tests included{color}.  The patch appears to be a documentation, build,
                        or dev patch that doesn't require tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 6 release audit warnings
(more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +            PreparedStatement stmt = conn.prepareStatement("UPSERT INTO " + tableName
+ " VALUES (?, ?, 'value2')");
+        PreparedStatement stmt = conn.prepareStatement("UPSERT INTO " + tableName + " SELECT
NEXT VALUE FOR "+ tableName + "_seq, val FROM " + tableName);
+        stmt.execute("CREATE TABLE " + fullTableName + "(pk INTEGER PRIMARY KEY, val INTEGER)"+tableDDLOptions);
+        stmt.execute("CREATE "+(localIndex? "LOCAL " : "")+"INDEX " + indexName + " ON "
+ fullTableName + "(val)");
+        String sqlStr = "UPSERT INTO " + fullTableName + " SELECT NEXT VALUE FOR " + seqName
+ ", val FROM " + fullTableName;

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ViewIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.txn.TxWriteFailureIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.ImmutableIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.UpgradeIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.tx.TxCheckpointIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.txn.RollbackIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.IndexRebuildTaskIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.tx.TransactionIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexFailureIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.TransactionalViewIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.GlobalMutableTxIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.execute.PartialCommitIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexFailureWithNamespaceIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.GlobalImmutableTxIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.schema.stats.TxStatsCollectorIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.tx.FlappingTransactionIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.StatsEnabledSplitSystemCatalogIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.rpc.UpdateCacheIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.txn.MutableRollbackIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.tx.ParameterizedTransactionIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.IndexToolIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexSplitForwardScanIT

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2535//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2535//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2535//console

This message is automatically generated.

> Iteratively executing the same SQL query will greatly damage the performance
> ----------------------------------------------------------------------------
>
>                 Key: PHOENIX-5224
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5224
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: bd2019us
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: 1.patch
>
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> Locations: 
> (1) phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexRebuildIncrementDisableCountIT.java:170
> (2) phoenix-core/src/it/java/org/apache/phoenix/tx/TxCheckpointIT.java:108
> (3) phoenix-core/src/it/java/org/apache/phoenix/end2end/DeleteIT.java:794,858
> (4) phoenix-core/src/it/java/org/apache/phoenix/end2end/UpsertSelectAutoCommitIT.java:240
> (5) phoenix-core/src/it/java/org/apache/phoenix/end2end/DropTableIT.java:35
> At these locations, the java.sql.Statement is intensively used in a loop and executing
the same SQL query, which will highly damage the performance of database access. In such cases,
java.sql.PreparedStatement should be used to enable the database compiling the SQL command
ahead of time, which has a much better performance compared with Statement.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message