phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Abhishek Singh Chouhan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-5203) Update contributing guidelines on Phoenix website
Date Tue, 16 Apr 2019 01:05:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-5203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16818491#comment-16818491
] 

Abhishek Singh Chouhan commented on PHOENIX-5203:
-------------------------------------------------

[~swaroopa] Patch breaks generating the website. Please refer to [https://phoenix.apache.org/building_website.html] for
build process.

> Update contributing guidelines on Phoenix website
> -------------------------------------------------
>
>                 Key: PHOENIX-5203
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5203
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Karan Mehta
>            Assignee: Swaroopa Kadam
>            Priority: Major
>         Attachments: PHOENIX-5203.master.v1.patch, PHOENIX-5203.master.v2.patch, PHOENIX-5203.master.v3.patch
>
>
> Add details about patch file naming convention, assumption that patch files only work
if it contains single commit in them (for Hadoop QA) and asking users to raise PR's as well
along with patch files since it makes it easier for others to review. This will help improve
onboarding.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message