phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-5203) Update contributing guidelines on Phoenix website
Date Wed, 10 Apr 2019 00:52:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-5203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16813944#comment-16813944
] 

Hadoop QA commented on PHOENIX-5203:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12965391/PHOENIX-5203.master.v3.patch
  against master branch at commit 6ca7ff61ca9d8d89343fb331aed25afe174c8ca5.
  ATTACHMENT ID: 12965391

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+0 tests included{color}.  The patch appears to be a documentation, build,
                        or dev patch that doesn't require tests.

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2503//console

This message is automatically generated.

> Update contributing guidelines on Phoenix website
> -------------------------------------------------
>
>                 Key: PHOENIX-5203
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5203
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Karan Mehta
>            Assignee: Swaroopa Kadam
>            Priority: Major
>         Attachments: PHOENIX-5203.master.v1.patch, PHOENIX-5203.master.v2.patch, PHOENIX-5203.master.v3.patch
>
>
> Add details about patch file naming convention, assumption that patch files only work
if it contains single commit in them (for Hadoop QA) and asking users to raise PR's as well
along with patch files since it makes it easier for others to review. This will help improve
onboarding.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message