phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mihir Monani (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-5195) PHERF:- Handle batch failure in connection.commit() in WriteWorkload#upsertData
Date Tue, 16 Apr 2019 12:01:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-5195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16818931#comment-16818931
] 

Mihir Monani commented on PHOENIX-5195:
---------------------------------------

[~karanmehta93] In general with Phoenix 4.14+ , exception are being thrown back to client
for index failures , for any batch which fails. Every client implementation needs to handle
this exception (by retry logic or by swallowing it).
In case of PHERF, every thread handles no of batches to insert and if we do not handle this
exception  then thread would abort. 
{quote}The upserted data will be inconsistent to what user/workload expects. Do you instead
want to bring in some kind of retry logic here?
{quote}
I think it would fine in case of PHERF as it would fail entire batch of data. I don't think
retry is required for PHERF client. 

> PHERF:- Handle batch failure in connection.commit() in  WriteWorkload#upsertData
> --------------------------------------------------------------------------------
>
>                 Key: PHOENIX-5195
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5195
>             Project: Phoenix
>          Issue Type: Sub-task
>    Affects Versions: 4.14.0, 5.0.0, 4.15.0, 4.14.1
>            Reporter: Mihir Monani
>            Assignee: Mihir Monani
>            Priority: Minor
>              Labels: pherf
>         Attachments: PHOENIX-5195-4.x-HBase-1.3.01.patch
>
>
> For Pherf tool,  If WriteWorkload#upsertBatch faces any exception in connection.commit()
during batch writes, pherf does not handle exception and aborts the thread. 
> Ref, [PHOENIX-5092|https://issues.apache.org/jira/browse/PHOENIX-5092] 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message