phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-5190) Implement a TaskRegionObserver for index rebuilds
Date Wed, 03 Apr 2019 22:35:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-5190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16809329#comment-16809329
] 

Hadoop QA commented on PHOENIX-5190:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12964737/PHOENIX-5190.patch
  against master branch at commit e8664d14d29ed3803e884f17d341593d41dcef6a.
  ATTACHMENT ID: 12964737

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 4 release audit warnings
(more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +            conn.createStatement().execute("DELETE " + " FROM " + PhoenixDatabaseMetaData.SYSTEM_TASK_NAME);
+            assertTaskColumns(conn, PTable.TaskStatus.COMPLETED.toString(), PTable.TaskType.DROP_CHILD_VIEWS,
null);
+            ResultSet rs = conn.createStatement().executeQuery("SELECT * FROM " + PhoenixDatabaseMetaData.SYSTEM_CATALOG_NAME
+
+    public static void assertTaskColumns(Connection conn, String expectedStatus, PTable.TaskType
taskType, String expectedData)
+        return String.format(format, "TENANT_ID VARCHAR NOT NULL, ", "TENANT_ID, ", optionsBuilder.toString());
+                        String.format("UPSERT INTO %s VALUES('%s', '%s', '%s')", viewName,
String.valueOf(i), "y",
+                            TaskRegionEnvironment, QueryServicesOptions.DEFAULT_TASK_HANDLING_MAX_INTERVAL_MS);
+            ConnectionQueryServices queryServices = conn.unwrap(PhoenixConnection.class).getQueryServices();
+            int count = getUtility().countRows(queryServices.getTable(Bytes.toBytes(viewIndexTableName)));
+            Table systemHTable= queryServices.getTable(Bytes.toBytes("SYSTEM."+PhoenixDatabaseMetaData.SYSTEM_TASK_TABLE));

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexSplitForwardScanIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.DropTableWithViewsIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexSplitReverseScanIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ChangePermissionsIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.TableDDLPermissionsIT

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2478//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2478//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2478//console

This message is automatically generated.

> Implement a TaskRegionObserver for index rebuilds
> -------------------------------------------------
>
>                 Key: PHOENIX-5190
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5190
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Gokcen Iskender
>            Assignee: Gokcen Iskender
>            Priority: Major
>         Attachments: PHOENIX-5190-4.x.patch, PHOENIX-5190.patch
>
>          Time Spent: 2h 50m
>  Remaining Estimate: 0h
>
> A new way to kick index rebuilds is putting an entry to System.Tasks table.
> IndexRebuildTask is a new TaskRegionObserver. It will look at this table, kick the index
rebuild and mark the task status.
> This work requires updates to the System.Tasks table.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message