phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <>
Subject [jira] [Commented] (PHOENIX-5138) ViewIndexId sequences created after PHOENIX-5132 shouldn't collide with ones created before it
Date Thu, 04 Apr 2019 01:48:00 GMT


Hadoop QA commented on PHOENIX-5138:

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment
  against master branch at commit 43600fbf39cda4336be9736fd8c653044e3d85ee.
  ATTACHMENT ID: 12964775

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 4 release audit warnings
(more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
    +    private Connection getConnection(boolean tenantSpecific, String tenantId, boolean
+    private void testMergeViewIndexSequencesHelper(boolean isNamespaceMappingEnabled) throws
Exception {
+        PhoenixConnection conn = getConnection(false, null, isNamespaceMappingEnabled).unwrap(PhoenixConnection.class);
+        PName viewIndexTable = PNameFactory.newName(MetaDataUtil.getViewIndexPhysicalName(tableName));
+            createViewIndexSequenceWithOldName(cqs, tenantOne, viewIndexTable, isNamespaceMappingEnabled);
+            createViewIndexSequenceWithOldName(cqs, tenantTwo, viewIndexTable, isNamespaceMappingEnabled);
+            createViewIndexSequenceWithOldName(cqs, null, viewIndexTable, isNamespaceMappingEnabled);
+        cqs.incrementSequences(allocations, EnvironmentEdgeManager.currentTimeMillis(), incrementedValues,
+        SequenceKey sequenceUpgrade = MetaDataUtil.getViewIndexSequenceKey(null, viewIndexTable,
0, isNamespaceMappingEnabled);
+        cqs.incrementSequences(afterUpgradeAllocations, EnvironmentEdgeManager.currentTimeMillis(),
afterUpgradeValues, afterUpgradeExceptions);

     {color:red}-1 core tests{color}.  The patch failed these unit tests:

Test results:
Release audit warnings:
Console output:

This message is automatically generated.

> ViewIndexId sequences created after PHOENIX-5132 shouldn't collide with ones created
before it
> ----------------------------------------------------------------------------------------------
>                 Key: PHOENIX-5138
>                 URL:
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.15.0, 5.1
>            Reporter: Geoffrey Jacoby
>            Assignee: Geoffrey Jacoby
>            Priority: Blocker
>             Fix For: 4.15.0, 5.1.0
>         Attachments: PHOENIX-5138-v2.patch, PHOENIX-5138-v3.patch, PHOENIX-5138.patch
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
> PHOENIX-5132 changed the ViewIndexId generation logic to use one sequence per physical
view index table, whereas before it had been tenant + physical table. This removed the possibility
of a tenant view index and a global view index having colliding ViewIndexIds.
> However, existing Phoenix environments may have already created tenant-owned view index
ids using the old sequence, and under PHOENIX-5132 if they create another, its ViewIndexId
will got back to MIN_VALUE, which could cause a collision with an existing view index id.

This message was sent by Atlassian JIRA

View raw message