phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <>
Subject [jira] [Commented] (PHOENIX-5130) removed 'static' keyword from 'private static enum'.
Date Sat, 27 Apr 2019 02:34:00 GMT


Hadoop QA commented on PHOENIX-5130:

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment
  against master branch at commit abe063fa20bac1c05f378152d3e5be6f22f0a7d6.
  ATTACHMENT ID: 12967191

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 6 release audit warnings
(more than the master's current 0 warnings).

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

     {color:red}-1 core tests{color}.  The patch failed these unit tests:

Test results:
Release audit warnings:
Console output:

This message is automatically generated.

> removed 'static' keyword from 'private static enum'.
> ----------------------------------------------------
>                 Key: PHOENIX-5130
>                 URL:
>             Project: Phoenix
>          Issue Type: Improvement
>    Affects Versions: 5.1.0
>            Reporter: Jeon, Il Woong
>            Priority: Trivial
>             Fix For: 5.1.0
>         Attachments: PHOENIX-5130.patch, PHOENIX-5130_2019_04_27.patch, PHOENIX-5130_2019_04_27.patch,
Screenshot from 2019-04-26 16-56-47.png
>   Original Estimate: 1m
>          Time Spent: 10m
>  Remaining Estimate: 0h
> Hello :)
> I did found 'private static enum'.
> 'static' keyword is unnecessary for enum type.
> 'Nested enum types are implicitly static('.
> So I removed 'static' keyword from 'private static enum'.
> []
> Thank you for reading.

This message was sent by Atlassian JIRA

View raw message