phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xinyi Yan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-5130) removed 'static' keyword from 'private static enum'.
Date Fri, 26 Apr 2019 23:09:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-5130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16827364#comment-16827364
] 

Xinyi Yan commented on PHOENIX-5130:
------------------------------------

[~glqdlt] can you also click the `submit patch` and re-upload your patch? 

> removed 'static' keyword from 'private static enum'.
> ----------------------------------------------------
>
>                 Key: PHOENIX-5130
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5130
>             Project: Phoenix
>          Issue Type: Improvement
>    Affects Versions: 5.1.0
>            Reporter: Jeon, Il Woong
>            Priority: Trivial
>             Fix For: 5.1.0
>
>         Attachments: PHOENIX-5130.patch
>
>   Original Estimate: 1m
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Hello :)
> I did found 'private static enum'.
> 'static' keyword is unnecessary for enum type.
> 'Nested enum types are implicitly static(https://docs.oracle.com/javase/specs/jls/se8/html/jls-8.html#jls-8.9)'.
> So I removed 'static' keyword from 'private static enum'.
> [https://github.com/apache/phoenix/pull/438]
> Thank you for reading.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message