phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [phoenix] priyankporwal commented on a change in pull request #495: PHOENIX-4703 Make indextool changes to drop before rebuild
Date Tue, 30 Apr 2019 23:42:53 GMT
priyankporwal commented on a change in pull request #495: PHOENIX-4703 Make indextool changes
to drop before rebuild
URL: https://github.com/apache/phoenix/pull/495#discussion_r279975974
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexTool.java
 ##########
 @@ -231,6 +241,11 @@ private CommandLine parseOptions(String[] args) {
 		if (cmdLine.hasOption(PARTIAL_REBUILD_OPTION.getOpt()) && cmdLine.hasOption(INDEX_TABLE_OPTION.getOpt()))
{
 			throw new IllegalStateException("Index name should not be passed with " + PARTIAL_REBUILD_OPTION.getLongOpt());
 		}
+
+        if (cmdLine.hasOption(PARTIAL_REBUILD_OPTION.getOpt()) && cmdLine.hasOption(DELETE_ALL_AND_REBUILD_OPTION.getOpt()))
{
 
 Review comment:
   Nit: Indentation issue here wrt if block on lines 241-243 above.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message