phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [phoenix] dbwong commented on a change in pull request #494: PHOENIX-5262 Wrong Result on Salted table with Varbinary PK
Date Tue, 30 Apr 2019 21:48:11 GMT
dbwong commented on a change in pull request #494: PHOENIX-5262 Wrong Result on Salted table
with Varbinary PK
URL: https://github.com/apache/phoenix/pull/494#discussion_r279949649
 
 

 ##########
 File path: phoenix-core/src/test/java/org/apache/phoenix/compile/WhereCompilerTest.java
 ##########
 @@ -183,7 +183,7 @@ public void testSingleFixedFullPkSalted() throws SQLException {
     @Test
     public void testSingleVariableFullPkSalted() throws SQLException {
         PhoenixConnection pconn = DriverManager.getConnection(getUrl(), PropertiesUtil.deepCopy(TEST_PROPERTIES)).unwrap(PhoenixConnection.class);
-        pconn.createStatement().execute("CREATE TABLE t (k varchar primary key, v varchar)
SALT_BUCKETS=20");
+        pconn.createStatement().execute("CREATE TABLE t (k varchar(10) primary key, v varchar)
SALT_BUCKETS=20");
 
 Review comment:
   As sycned offline, I'll add an arraytype E2E test as this does affect any variable-length
field and I believe that I can construct a failing E2E for it unlike varchar.  I will also
update the PR/Jira/Commit text to reflect.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message