phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [phoenix] yanxinyi commented on a change in pull request #482: PHOENIX-4925 Use Segment tree to organize Guide Post Info
Date Mon, 29 Apr 2019 23:02:27 GMT
yanxinyi commented on a change in pull request #482: PHOENIX-4925 Use Segment tree to organize
Guide Post Info
URL: https://github.com/apache/phoenix/pull/482#discussion_r279570077
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/compile/ScanRanges.java
 ##########
 @@ -374,9 +375,19 @@ public Scan intersectScan(Scan scan, final byte[] originalStartKey,
final byte[]
         if (scanStopKey.length > 0 && Bytes.compareTo(scanStartKey, scanStopKey)
>= 0) { 
             return null; 
         }
+
+        ImmutableBytesWritable a1 = new ImmutableBytesWritable(scanStartKey);
+        ImmutableBytesWritable b1 = new ImmutableBytesWritable(scanStopKey);
+        byte[] a1StartKey = a1.copyBytes();
+        byte[] b1StartKey = b1.copyBytes();
+        newScan.setAttribute(SCAN_ACTUAL_START_ROW, a1StartKey);
+        newScan.setStartRow(a1StartKey);
+        newScan.setStopRow(b1StartKey);
+        /*
         newScan.setAttribute(SCAN_ACTUAL_START_ROW, scanStartKey);
 
 Review comment:
   why do we need to keep the old code here? 
   From my point of view, `setStartRow` and `setStopRow` APIs are deprecated, and it will
remove soon.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message