phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [phoenix] priyankporwal commented on a change in pull request #469: PHOENIX-5156 Consistent Global Indexes for Non-Transactional Tables
Date Mon, 29 Apr 2019 18:42:45 GMT
priyankporwal commented on a change in pull request #469: PHOENIX-5156 Consistent Global Indexes
for Non-Transactional Tables
URL: https://github.com/apache/phoenix/pull/469#discussion_r279109142
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/util/UpgradeUtil.java
 ##########
 @@ -1418,6 +1420,14 @@ public static void syncTableAndIndexProperties(PhoenixConnection conn,
Admin adm
                 continue;
             }
             if (table.getType() == PTableType.INDEX) {
+                if (table.getIndexType() == IndexType.GLOBAL &&
+                        !table.isTransactional() &&
+                        !table.isImmutableRows() &&
 
 Review comment:
   Should the isTransactional() and isImmutableRows() checks be done on the originalTableDesc
or the index table?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message