phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [phoenix] kadirozde commented on a change in pull request #469: PHOENIX-5156 Consistent Global Indexes for Non-Transactional Tables
Date Fri, 26 Apr 2019 03:01:28 GMT
kadirozde commented on a change in pull request #469: PHOENIX-5156 Consistent Global Indexes
for Non-Transactional Tables
URL: https://github.com/apache/phoenix/pull/469#discussion_r278795174
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/util/IndexUtil.java
 ##########
 @@ -849,4 +857,59 @@ public static long getIndexPendingDisableCount(PhoenixConnection conn,
String fa
             throw new IOException(e);
         }
     }
+
+    private static boolean containsOneOrMoreColumn(Scan scan) {
+        Map<byte[], NavigableSet<byte[]>> familyMap = scan.getFamilyMap();
+        if (familyMap == null || familyMap.isEmpty()) {
+            return false;
+        }
+        for (Map.Entry<byte[], NavigableSet<byte[]>> entry : familyMap.entrySet())
{
+            NavigableSet<byte[]> family = entry.getValue();
+            if (family != null && !family.isEmpty()) {
+                return true;
+            }
+        }
+        return false;
+    }
+
+    private static void updateScan(Scan scan, byte[] emptyCF, byte[] emptyCQ) {
+        if (containsOneOrMoreColumn(scan)) {
+            scan.addColumn(emptyCF, emptyCQ);
+            return;
+        }
+        return;
+    }
+
+    public static void setScanAttributes(Scan scan, PTable table, PhoenixConnection phoenixConnection)
throws SQLException {
+        if (table.isTransactional() || table.isImmutableRows() || table.getType() != PTableType.INDEX)
{
+            return;
+        }
+        PTable indexTable = table;
+        if (indexTable.getIndexType() != PTable.IndexType.GLOBAL) {
+            return;
+        }
+        String schemaName = indexTable.getParentSchemaName().getString();
+        String tableName = indexTable.getParentTableName().getString();
+        PTable dataTable = PhoenixRuntime.getTable(phoenixConnection, SchemaUtil.getTableName(schemaName,
tableName));
 
 Review comment:
   I am not sure about the answer to your question. I agree that non-cached version would
be safer but why do we have the cached version then and when to use cached versus non-cache?
I did not want to impact the performance here. @twdsilva, do we have any guidelines on this?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message