phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [phoenix] kadirozde commented on a change in pull request #469: PHOENIX-5156 Consistent Global Indexes for Non-Transactional Tables
Date Fri, 26 Apr 2019 02:54:31 GMT
kadirozde commented on a change in pull request #469: PHOENIX-5156 Consistent Global Indexes
for Non-Transactional Tables
URL: https://github.com/apache/phoenix/pull/469#discussion_r278794340
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java
 ##########
 @@ -942,6 +942,9 @@ private boolean addIndexesFromParentTable(MetaDataMutationResult result,
Long re
                 } else {
                     indexesToAdd.add(PTableImpl.builderWithColumns(index, getColumnsToClone(index))
                             .setTableName(modifiedIndexName)
+                            .setParentName(view.getName())
 
 Review comment:
   This is a bug on the existing code where the parent table name is not set properly when
the index name are generated  for views. My code triggers this bug when the code attempts
to get index maintainers for a given view. @twdsilva suggested this would be the fix and it
fixed the issue.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message