phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [phoenix-queryserver] karanmehta93 commented on a change in pull request #5: PHOENIX-5255: Create Orchestrator for QueryServerCanaryTool in phoenix-queryserver project
Date Thu, 25 Apr 2019 04:40:36 GMT
karanmehta93 commented on a change in pull request #5: PHOENIX-5255: Create Orchestrator for
QueryServerCanaryTool in phoenix-queryserver project
URL: https://github.com/apache/phoenix-queryserver/pull/5#discussion_r278394002
 
 

 ##########
 File path: queryserver-orchestrator/src/main/java/org/apache/phoenix/queryserver/orchestrator/LoggingCanarySink.java
 ##########
 @@ -0,0 +1,75 @@
+package org.apache.phoenix.queryserver.orchestrator;
+
+import com.google.common.annotations.VisibleForTesting;
+import com.google.common.base.Preconditions;
+import com.google.common.base.Strings;
+import com.google.gson.Gson;
+import com.google.gson.GsonBuilder;
+import org.apache.phoenix.tool.CanaryTestResult;
+import org.apache.phoenix.tool.PhoenixCanaryTool;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.text.SimpleDateFormat;
+import java.util.ArrayList;
+import java.util.Date;
+import java.util.List;
+
+public class LoggingCanarySink implements PhoenixCanaryTool.Sink {
 
 Review comment:
   nit: please add descriptive comments for all relevant classes and methods

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message