phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [phoenix] dbwong commented on a change in pull request #485: Add common utility function ScanUtil.splityKeyRangesByBoundaries()
Date Wed, 17 Apr 2019 01:13:09 GMT
dbwong commented on a change in pull request #485: Add common utility function ScanUtil.splityKeyRangesByBoundaries()
URL: https://github.com/apache/phoenix/pull/485#discussion_r276038641
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/query/KeyRange.java
 ##########
 @@ -519,16 +519,21 @@ public KeyRange union(KeyRange other) {
         return Lists.transform(keys, POINT);
     }
 
-    public static int compareUpperRange(KeyRange rowKeyRange1,KeyRange rowKeyRange2) {
-        int result = Boolean.compare(rowKeyRange1.upperUnbound(), rowKeyRange2.upperUnbound());
+    public int compareUpperRange(byte[] b, int o, int l, boolean isInclusive) {
 
 Review comment:
   Please add unit test for this function.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message