phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [phoenix] dbwong commented on a change in pull request #479: PHOENIX-5231 Configurable Stats Cache
Date Mon, 15 Apr 2019 21:50:17 GMT
dbwong commented on a change in pull request #479: PHOENIX-5231 Configurable Stats Cache
URL: https://github.com/apache/phoenix/pull/479#discussion_r275558425
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
 ##########
 @@ -420,8 +421,11 @@ public ConnectionQueryServicesImpl(QueryServices services, ConnectionInfo
connec
             list.add(queue);
         }
         connectionQueues = ImmutableList.copyOf(list);
+
         // A little bit of a smell to leak `this` here, but should not be a problem
-        this.tableStatsCache = new GuidePostsCache(this, config);
+        this.tableStatsCache = queryServicesHelper.getGuidePostsCache(props.get(GUIDE_POSTS_CACHE_FACTORY_CLASS,
+                QueryServicesOptions.DEFAULT_GUIDE_POSTS_CACHE_FACTORY_CLASS), this, config);
 
 Review comment:
   So I spent most of my time looking at this and deciding if I can/should address this now.
 After discussion I want to make a new JIRA and address in a separate PR.  This change for
this escaping likely needs to go all the way to the PhoenixDriver level to properly handle
this creation as well as disentangle the queryServices and the stats cache.  Are you okay
with this @karanmehta93 ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message