phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [phoenix] gjacoby126 commented on a change in pull request #469: PHOENIX-5156 Consistent Global Indexes for Non-Transactional Tables
Date Wed, 10 Apr 2019 22:38:41 GMT
gjacoby126 commented on a change in pull request #469: PHOENIX-5156 Consistent Global Indexes
for Non-Transactional Tables
URL: https://github.com/apache/phoenix/pull/469#discussion_r274190836
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/HashJoinRegionScanner.java
 ##########
 @@ -74,18 +75,18 @@
     private final boolean addArrayCell;
 
     @SuppressWarnings("unchecked")
-    public HashJoinRegionScanner(RegionScanner scanner, TupleProjector projector,
+    public HashJoinRegionScanner(RegionScanner scanner, Scan scan, TupleProjector projector,
                                  HashJoinInfo joinInfo, ImmutableBytesPtr tenantId,
                                  RegionCoprocessorEnvironment env, boolean useQualifierAsIndex,
                                  boolean useNewValueColumnQualifier)
         throws IOException {
 
-        this(env, scanner, null, null, projector, joinInfo,
+        this(env, scanner, scan,null, null, projector, joinInfo,
              tenantId, useQualifierAsIndex, useNewValueColumnQualifier);
     }
 
     @SuppressWarnings("unchecked")
-    public HashJoinRegionScanner(RegionCoprocessorEnvironment env, RegionScanner scanner,
+    public HashJoinRegionScanner(RegionCoprocessorEnvironment env, RegionScanner scanner,
Scan scan,
                                  final Set<KeyValueColumnExpression> arrayKVRefs,
 
 Review comment:
   I also do not see where HashJoinRegionScanner uses the new scan parameter. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message