phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [phoenix] karanmehta93 commented on a change in pull request #479: PHOENIX-5231 Configurable Stats Cache
Date Tue, 09 Apr 2019 22:42:52 GMT
karanmehta93 commented on a change in pull request #479: PHOENIX-5231 Configurable Stats Cache
URL: https://github.com/apache/phoenix/pull/479#discussion_r273732957
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/query/QueryServicesHelper.java
 ##########
 @@ -0,0 +1,68 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.phoenix.query;
+
+import com.google.common.annotations.VisibleForTesting;
+import com.google.common.base.Preconditions;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.phoenix.exception.PhoenixNonRetryableRuntimeException;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class QueryServicesHelper {
+
+    private static final Logger LOGGER = LoggerFactory.getLogger(QueryServicesHelper.class);
+
+    // Singleton protected by synchronized method
+    static GuidePostsCacheFactory guidePostsCacheFactory = null;
 
 Review comment:
   Should this be static? We want different factories for each `CQS` instance, which essentially
boils down to connection URL, right? Am I missing some context here? @dbwong 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message