phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [phoenix] karanmehta93 commented on a change in pull request #479: PHOENIX-5231 Configurable Stats Cache
Date Tue, 09 Apr 2019 20:51:26 GMT
karanmehta93 commented on a change in pull request #479: PHOENIX-5231 Configurable Stats Cache
URL: https://github.com/apache/phoenix/pull/479#discussion_r273694446
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionlessQueryServicesImpl.java
 ##########
 @@ -600,7 +604,12 @@ public String getUserName() {
 
     @Override
     public GuidePostsInfo getTableStats(GuidePostsKey key) {
-        GuidePostsInfo info = guidePostsCache.getCache().getIfPresent(key);
+        GuidePostsInfo info = null;
 
 Review comment:
   Do we need to handle this exception in a similar way in `ConnectionQueryServicesImpl.java`?
   We may not be able to move to parent class because I believe that Java 7 doesn't support
default methods in interfaces, right? Do you think there is a better way?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message