phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [phoenix] gjacoby126 commented on a change in pull request #473: PHOENIX-5138 - ViewIndexId sequences created after PHOENIX-5132 shoul…
Date Mon, 08 Apr 2019 23:17:54 GMT
gjacoby126 commented on a change in pull request #473: PHOENIX-5138 - ViewIndexId sequences
created after PHOENIX-5132 shoul…
URL: https://github.com/apache/phoenix/pull/473#discussion_r273274143
 
 

 ##########
 File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/index/ViewIndexIT.java
 ##########
 @@ -153,15 +153,10 @@ public void testDeleteViewIndexSequences() throws Exception {
         conn2.createStatement().executeQuery("SELECT * FROM " + fullTableName).next();
         String sequenceName = getViewIndexSequenceName(PNameFactory.newName(fullTableName),
null, isNamespaceMapped);
         String sequenceSchemaName = getViewIndexSequenceSchemaName(PNameFactory.newName(fullTableName),
isNamespaceMapped);
-        String seqName = getViewIndexSequenceName(PNameFactory.newName(fullTableName), null,
!isNamespaceMapped);
-        String seqSchemaName = getViewIndexSequenceSchemaName(PNameFactory.newName(fullTableName),
!isNamespaceMapped);
         verifySequenceValue(null, sequenceName, sequenceSchemaName, -9223372036854775807L);
         verifySequenceValue(null, sequenceName, sequenceSchemaName, -9223372036854775807L);
         conn1.createStatement().execute("CREATE INDEX " + indexName + "_2 ON " + fullViewName
+ " (v1)");
         verifySequenceValue(null, sequenceName, sequenceSchemaName, -9223372036854775806L);
 
 Review comment:
   The test is verifying that a CREATE INDEX statement on a view will increment the sequence.
And yes, it would be more clear with a constant, because they're offsets of Long.MIN_VALUE.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message