phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [phoenix] BinShi-SecularBird commented on a change in pull request #471: PHOENIX-5176 KeyRange.compareUpperRange(KeyRang 1, KeyRang 2) returns wrong result when two key ranges have the same upper bound values but one is inclusive and another is exclusive
Date Sat, 06 Apr 2019 17:06:58 GMT
BinShi-SecularBird commented on a change in pull request #471: PHOENIX-5176 KeyRange.compareUpperRange(KeyRang
1, KeyRang 2) returns wrong result when two key ranges have the same upper bound values but
one is inclusive and another is exclusive
URL: https://github.com/apache/phoenix/pull/471#discussion_r272802157
 
 

 ##########
 File path: phoenix-core/src/test/java/org/apache/phoenix/query/KeyRangeMoreTest.java
 ##########
 @@ -23,6 +23,7 @@
 import java.util.Collections;
 import java.util.List;
 
+import org.apache.curator.shaded.com.google.common.collect.Lists;
 
 Review comment:
   org.apache.curator.shaded.com.google.common.collect.Lists is used by old test code in this
file and has nothing to do with my change. I searched in phoenix-core, there are test files
using it. If we want to unify the coding style/rules and replace all the places using org.apache.curator.shaded.com.google.common.collect.Lists
with JDK standard Lists, we should open an JIRA and make the change in whole code base, but
it is orthogonal to and shouldn't be addressed in my change.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message