phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [phoenix] swaroopak commented on a change in pull request #473: PHOENIX-5138 - ViewIndexId sequences created after PHOENIX-5132 shoul…
Date Fri, 05 Apr 2019 21:08:50 GMT
swaroopak commented on a change in pull request #473: PHOENIX-5138 - ViewIndexId sequences
created after PHOENIX-5132 shoul…
URL: https://github.com/apache/phoenix/pull/473#discussion_r272732631
 
 

 ##########
 File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/index/ViewIndexIT.java
 ##########
 @@ -153,15 +153,10 @@ public void testDeleteViewIndexSequences() throws Exception {
         conn2.createStatement().executeQuery("SELECT * FROM " + fullTableName).next();
         String sequenceName = getViewIndexSequenceName(PNameFactory.newName(fullTableName),
null, isNamespaceMapped);
         String sequenceSchemaName = getViewIndexSequenceSchemaName(PNameFactory.newName(fullTableName),
isNamespaceMapped);
-        String seqName = getViewIndexSequenceName(PNameFactory.newName(fullTableName), null,
!isNamespaceMapped);
-        String seqSchemaName = getViewIndexSequenceSchemaName(PNameFactory.newName(fullTableName),
!isNamespaceMapped);
         verifySequenceValue(null, sequenceName, sequenceSchemaName, -9223372036854775807L);
         verifySequenceValue(null, sequenceName, sequenceSchemaName, -9223372036854775807L);
         conn1.createStatement().execute("CREATE INDEX " + indexName + "_2 ON " + fullViewName
+ " (v1)");
         verifySequenceValue(null, sequenceName, sequenceSchemaName, -9223372036854775806L);
 
 Review comment:
   Just curious, I see there is a difference in the last digit. any particular significance?
while you are at it, can we extract this value to a constant?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message