phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [phoenix] swaroopak commented on a change in pull request #473: PHOENIX-5138 - ViewIndexId sequences created after PHOENIX-5132 shoul…
Date Fri, 05 Apr 2019 21:08:50 GMT
swaroopak commented on a change in pull request #473: PHOENIX-5138 - ViewIndexId sequences
created after PHOENIX-5132 shoul…
URL: https://github.com/apache/phoenix/pull/473#discussion_r272743319
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/util/UpgradeUtil.java
 ##########
 @@ -2243,15 +2249,14 @@ private static void updateIndexesSequenceIfPresent(PhoenixConnection
connection,
         String newSchemaName = MetaDataUtil.getViewIndexSequenceSchemaName(physicalName,
true);
         String newSequenceName = MetaDataUtil.getViewIndexSequenceName(physicalName, tenantId,
true);
         // create new entry with new schema format
-        String upsert = "UPSERT INTO " + PhoenixDatabaseMetaData.SYSTEM_SEQUENCE + " SELECT
 REGEXP_SPLIT("
-                + PhoenixDatabaseMetaData.SEQUENCE_NAME + ",'_')[3] ,\'" + newSchemaName
+ "\',\'" + newSequenceName
+        String upsert = "UPSERT INTO " + PhoenixDatabaseMetaData.SYSTEM_SEQUENCE + " SELECT
NULL,\'" + newSchemaName +
+            "\',\'" + newSequenceName
                 + "\'," + START_WITH + "," + CURRENT_VALUE + "," + INCREMENT_BY + "," + CACHE_SIZE
+ "," + MIN_VALUE
                 + "," + MAX_VALUE + "," + CYCLE_FLAG + "," + LIMIT_REACHED_FLAG + " FROM
"
                 + PhoenixDatabaseMetaData.SYSTEM_SEQUENCE + " WHERE " + PhoenixDatabaseMetaData.TENANT_ID
                 + " IS NULL AND " + PhoenixDatabaseMetaData.SEQUENCE_SCHEMA + " = '" + oldSchemaName
+ "'";
         connection.createStatement().executeUpdate(upsert);
         // delete old sequence
 
 Review comment:
   nit: unrelated comment
   one of the reasons, I don't prefer commenting inline. :D 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message