phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [phoenix] swaroopak commented on a change in pull request #473: PHOENIX-5138 - ViewIndexId sequences created after PHOENIX-5132 shoul…
Date Fri, 05 Apr 2019 21:08:49 GMT
swaroopak commented on a change in pull request #473: PHOENIX-5138 - ViewIndexId sequences
created after PHOENIX-5132 shoul…
URL: https://github.com/apache/phoenix/pull/473#discussion_r272712434
 
 

 ##########
 File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/UpgradeIT.java
 ##########
 @@ -588,4 +587,87 @@ public void testMoveParentChildLinks() throws Exception {
         return childLinkSet;
     }
 
+    @Test
+    public void testMergeViewIndexSequences() throws Exception {
+        testMergeViewIndexSequencesHelper(false);
+    }
+
+    @Test
+    public void testMergeViewIndexSequencesWithNamespaces() throws Exception {
+        testMergeViewIndexSequencesHelper(true);
 
 Review comment:
   I feel there is some way to create a parameterized test suite out of this. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message