phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [phoenix] yanxinyi commented on a change in pull request #476: PHOENIX-5228 use slf4j for logging in phoenix project
Date Fri, 05 Apr 2019 19:09:56 GMT
yanxinyi commented on a change in pull request #476: PHOENIX-5228 use slf4j for logging in
phoenix project
URL: https://github.com/apache/phoenix/pull/476#discussion_r272711083
 
 

 ##########
 File path: phoenix-core/src/it/java/org/apache/hadoop/hbase/regionserver/wal/WALRecoveryRegionPostOpenIT.java
 ##########
 @@ -75,14 +73,16 @@
 import org.junit.BeforeClass;
 import org.junit.Test;
 import org.junit.experimental.categories.Category;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 import com.google.common.collect.Maps;
 import com.google.common.collect.Multimap;
 
 @Category(NeedsOwnMiniClusterTest.class)
 public class WALRecoveryRegionPostOpenIT extends BaseTest {
 
-    private static final Log LOG = LogFactory.getLog(WALRecoveryRegionPostOpenIT.class);
+    private static final Logger logger = LoggerFactory.getLogger(WALRecoveryRegionPostOpenIT.class);
 
 Review comment:
   I didn't plan to change var name in the first place until I got Mihir's comment. 
   See https://issues.apache.org/jira/browse/PHOENIX-5228
   `We should change variable names for log object also, from LOG to logger , it would be
simpler and common across the phoenix project. `

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message