phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [phoenix] swaroopak commented on a change in pull request #474: PHOENIX-5224 Change 'Statement' to 'PreparedStatement' for better performance
Date Fri, 05 Apr 2019 19:09:19 GMT
swaroopak commented on a change in pull request #474: PHOENIX-5224 Change 'Statement' to 'PreparedStatement'
for better performance
URL: https://github.com/apache/phoenix/pull/474#discussion_r272710885
 
 

 ##########
 File path: phoenix-core/src/it/java/org/apache/phoenix/tx/TxCheckpointIT.java
 ##########
 @@ -104,9 +105,9 @@ public void testUpsertSelectDoesntSeeUpsertedData() throws Exception
{
         conn.createStatement().execute("CREATE "+(localIndex? "LOCAL " : "")+"INDEX " + indexName
+ " ON " + fullTableName + "(val)");
 
 Review comment:
   while you are at it, Could you please logically separate this line of code? Lots of things
happening in one line.
   
   Thanks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message