From issues-return-5037-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Mon Mar 11 12:54:13 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id BF79A180657 for ; Mon, 11 Mar 2019 13:54:12 +0100 (CET) Received: (qmail 37862 invoked by uid 500); 11 Mar 2019 12:54:11 -0000 Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list issues@phoenix.apache.org Received: (qmail 37852 invoked by uid 99); 11 Mar 2019 12:54:11 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Mar 2019 12:54:11 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 59B1B180653 for ; Mon, 11 Mar 2019 12:54:11 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id RP8SWRqQulZR for ; Mon, 11 Mar 2019 12:54:10 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id EED925F659 for ; Mon, 11 Mar 2019 12:46:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 97653E27D4 for ; Mon, 11 Mar 2019 12:46:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 34B3C25806 for ; Mon, 11 Mar 2019 12:46:00 +0000 (UTC) Date: Mon, 11 Mar 2019 12:46:00 +0000 (UTC) From: "Hadoop QA (JIRA)" To: issues@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PHOENIX-5186) Remove redundant check for local in metadata client MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-5186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16789506#comment-16789506 ] Hadoop QA commented on PHOENIX-5186: ------------------------------------ {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12961969/PHOENIX-5186.4.x-HBase-1.3.patch against 4.x-HBase-1.3 branch at commit 26d3734d3c2a05c56e92a0ea09a99fd90059f568. ATTACHMENT ID: 12961969 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:red}-1 patch{color}. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2412//console This message is automatically generated. > Remove redundant check for local in metadata client > --------------------------------------------------- > > Key: PHOENIX-5186 > URL: https://issues.apache.org/jira/browse/PHOENIX-5186 > Project: Phoenix > Issue Type: Improvement > Affects Versions: 4.14.1 > Reporter: Aman Poonia > Assignee: Aman Poonia > Priority: Minor > Attachments: PHOENIX-5186.4.x-HBase-1.3.patch > > > Remove redundant check for local index type in metadata client > {code:java} > if (index.getIndexType() != IndexType.LOCAL) { > if (index.getIndexType() != IndexType.LOCAL) { > if (table.getType() != PTableType.VIEW) { > rowCount += updateStatisticsInternal(index.getPhysicalName(), index, > updateStatisticsStmt.getProps(), true); > } else { > rowCount += updateStatisticsInternal(table.getPhysicalName(), index, > updateStatisticsStmt.getProps(), true); > } > } > }{code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)