From issues-return-5028-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Sat Mar 9 06:38:04 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 1A74418062C for ; Sat, 9 Mar 2019 07:38:03 +0100 (CET) Received: (qmail 51465 invoked by uid 500); 9 Mar 2019 06:38:03 -0000 Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list issues@phoenix.apache.org Received: (qmail 51456 invoked by uid 99); 9 Mar 2019 06:38:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 09 Mar 2019 06:38:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id B8A23185B63 for ; Sat, 9 Mar 2019 06:38:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id YRlO_-76yaHD for ; Sat, 9 Mar 2019 06:38:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 38F1D5FB44 for ; Sat, 9 Mar 2019 06:38:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 57644E00E1 for ; Sat, 9 Mar 2019 06:38:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 12815257F1 for ; Sat, 9 Mar 2019 06:38:00 +0000 (UTC) Date: Sat, 9 Mar 2019 06:38:00 +0000 (UTC) From: "Hudson (JIRA)" To: issues@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PHOENIX-5182) Deprecate getTotalSum API of the GlobalMetric interface MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-5182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16788535#comment-16788535 ] Hudson commented on PHOENIX-5182: --------------------------------- FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #2406 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/2406/]) PHOENIX-5182: Deprecate getTotalSum API of the GlobalMetric interface (chinmayskulkarni: rev 26d3734d3c2a05c56e92a0ea09a99fd90059f568) * (edit) phoenix-core/src/it/java/org/apache/phoenix/execute/PartialCommitIT.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixMetricsDisabledIT.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixMetricsIT.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/monitoring/GlobalMetric.java > Deprecate getTotalSum API of the GlobalMetric interface > ------------------------------------------------------- > > Key: PHOENIX-5182 > URL: https://issues.apache.org/jira/browse/PHOENIX-5182 > Project: Phoenix > Issue Type: Improvement > Reporter: Chinmay Kulkarni > Assignee: Chinmay Kulkarni > Priority: Major > Fix For: 4.13.0, 4.14.0, 4.13.1, 5.0.0, 4.15.0, 4.14.1, 5.1.0 > > Attachments: PHOENIX-5182.patch > > Time Spent: 40m > Remaining Estimate: 0h > > The GlobalMetric interface has a getTotalSum API which is not of much value. The only implementation of this interface GlobalMetricImpl (which is not no-op) basically does a getValue for the metric when we call getTotalSum, which is confusing. We should deprecate it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)