From issues-return-5106-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Thu Mar 14 02:53:05 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 84DF818064A for ; Thu, 14 Mar 2019 03:53:04 +0100 (CET) Received: (qmail 36537 invoked by uid 500); 14 Mar 2019 02:53:03 -0000 Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list issues@phoenix.apache.org Received: (qmail 36526 invoked by uid 99); 14 Mar 2019 02:53:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 Mar 2019 02:53:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id F3878C28FE for ; Thu, 14 Mar 2019 02:53:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id mHPaadikzGik for ; Thu, 14 Mar 2019 02:53:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 25FF161143 for ; Thu, 14 Mar 2019 02:53:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6F6EFE2818 for ; Thu, 14 Mar 2019 02:53:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 173B124593 for ; Thu, 14 Mar 2019 02:53:00 +0000 (UTC) Date: Thu, 14 Mar 2019 02:53:00 +0000 (UTC) From: "Abhishek Singh Chouhan (JIRA)" To: issues@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PHOENIX-5131) Make spilling to disk for order/group by configurable MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-5131?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16= 792286#comment-16792286 ]=20 Abhishek Singh Chouhan commented on PHOENIX-5131: ------------------------------------------------- Thanks for having a look [~ckulkarni]. Since the runtimeexception gets wrap= ped into a phoenixioexception, i wanted the tests to test for the specific = scenario of the queue becoming full and not result in=C2=A0test passing for= any other kind of phoenixioexception(different cause) both for server and = client side exception. Abstract queue's default add implementation calls of= fer which i'm piggybacking on, my intention of overriding the add was just = to give a more meaningful message with the exception so the client gets a c= lear picture. I can however add a comment there if it helps. > Make spilling to disk for order/group by configurable > ----------------------------------------------------- > > Key: PHOENIX-5131 > URL: https://issues.apache.org/jira/browse/PHOENIX-5131 > Project: Phoenix > Issue Type: Improvement > Reporter: Abhishek Singh Chouhan > Assignee: Abhishek Singh Chouhan > Priority: Major > Fix For: 4.15.0, 5.1.0 > > Attachments: PHOENIX-5131-4.x-HBase-1.4.patch, PHOENIX-5131-maste= r-v2.patch, PHOENIX-5131-master-v2.patch, PHOENIX-5131-master-v3.patch, PHO= ENIX-5131-master-v4.patch, PHOENIX-5131-master.patch, PHOENIX-5131-master.p= atch > > > We've observed that large queries, doing order/group by=C2=A0leading to i= ssues on the regionserver (crashes/long gc pauses/file handler exhaustion e= tc.). We should make spilling to disk configurable and in case its disabled= , fail the query once it hits the spilling limit on any of the region serve= rs. Also make=C2=A0spooling threshold server-side property only to prevent = clients from controlling memory allocation on the rs side. -- This message was sent by Atlassian JIRA (v7.6.3#76005)